OAK-10423 - Improve logging of metrics in the indexing job #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tihom88
approved these changes
Sep 7, 2023
fabriziofortino
approved these changes
Sep 7, 2023
mbaedke
pushed a commit
that referenced
this pull request
Sep 19, 2023
* Improve logging of metrics in the indexing job. * Add integrity checks to the metrics formatter * Clean up log messages * Add logging of metrics to reindex, merge in node store and total job time. * Improve logging * Add missing license header. Fix typo in class name. * Simplify logic. * Print elapsed time in hours:minutes instead of decimal minutes. * Do not call .name() on reference that is potentially null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each phase/task of the indexing job, log messages at the start and end following a standard format. The messages at the end include metrics in JSON format.
Example: