Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAK-10427: Clear cache on NodeDocumentCache close #1098

Merged
merged 1 commit into from Sep 5, 2023
Merged

OAK-10427: Clear cache on NodeDocumentCache close #1098

merged 1 commit into from Sep 5, 2023

Conversation

mreutegg
Copy link
Contributor

@mreutegg mreutegg commented Sep 4, 2023

No description provided.

@rishabhdaim
Copy link
Contributor

We need to close changeTrackers as well.

@mreutegg
Copy link
Contributor Author

mreutegg commented Sep 5, 2023

We need to close changeTrackers as well.

That list only contains entries when trackers are in use. This is only the case during some DocumentStore operations, which means the list should generally be small or even empty. I'd rather not make changes, unless we know there is a problem.

@mreutegg mreutegg merged commit a90f97d into apache:trunk Sep 5, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabhdaim rishabhdaim rishabhdaim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mreutegg @rishabhdaim