OAK-10441: exclude snakeyaml from oak-search-elastic #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joerghoh
approved these changes
Sep 8, 2023
nfsantos
reviewed
Sep 8, 2023
nfsantos
approved these changes
Sep 8, 2023
fabriziofortino
changed the title
fabriziofortino
added a commit
to fabriziofortino/jackrabbit-oak
that referenced
this pull request
Sep 12, 2023
…pache#1110)"" This reverts commit 2a0ecd4.
fabriziofortino
added a commit
that referenced
this pull request
Sep 13, 2023
* Revert "Revert "OAK-10441: exclude snakeyaml from oak-search-elastic (#1110)"" This reverts commit 2a0ecd4. * OAK-10441: exclude package org.yaml.snakeyam.*
mbaedke
pushed a commit
that referenced
this pull request
Sep 19, 2023
* Revert "Revert "OAK-10441: exclude snakeyaml from oak-search-elastic (#1110)"" This reverts commit 2a0ecd4. * OAK-10441: exclude package org.yaml.snakeyam.*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://nvd.nist.gov/vuln/detail/CVE-2022-1471
snakeyaml 1.33 is vulnerable to remote code execution. A better solution would be to get rid of the es high-level client completely. This would require more time because of the changes needed to replace the bulk processor.
We can safely exclude this dependency since it's not used in our codebase.
As part of this PR, the es clients have been updated to the latest patch release.