OAK-8646 : added metrics for unmergedbranch commits & improved junit coverage #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-egli
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
+1, let's merge this.
A few after the fact comments:
- I would have preferred to get OAK-8646 : Clean up changes from orphaned branch commits #1090 done before adding metrics on top. Reason is that the way it's done now breaks the git PR review process and makes it virtually impossible to properly address PR review comments therefore - besides making the review itself unnecessarily much harder.
- Different people might have different preferences when it comes to "stream type processing". As of now, some of the review comments in OAK-8646 : Clean up changes from orphaned branch commits #1090 have been piggybacked into the OAK-8646 : added metrics for unmergedbranch commits & improved junit coverage #1111 directly, without awaiting PR review comments. So from the current state we'd have to revert it first in this PR were we to revisit that aspect. For this reason I believe it's fine, let's merge this. But there might have been a possibility to discuss pros/cons or just revisit that aspect - which I believe with the OAK-8646 : Clean up changes from orphaned branch commits #1090 / OAK-8646 : added metrics for unmergedbranch commits & improved junit coverage #1111 mixup was made impossible. That would be another reason for preference of doing PRs sequentially, not combined.
But overall I think let's merge and then revisit the state in the feature branch if needed.
maybe we can try to fix that... |
rishabhdaim
force-pushed
the
DetailedGC/OAK-10199
branch
from
76e1ee4
to
36f9ac6
Compare
Fixed in 88db3b0 |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.