Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAK-10429: Implementation for IncrementalFFS #1123

Merged
merged 14 commits into from
Sep 26, 2023
Merged

OAK-10429: Implementation for IncrementalFFS #1123

merged 14 commits into from
Sep 26, 2023

Conversation

tihom88
Copy link
Contributor

@tihom88 tihom88 commented Sep 16, 2023

No description provided.

fabriziofortino
fabriziofortino requested changes Sep 18, 2023
View reviewed changes
...src/main/java/org/apache/jackrabbit/oak/index/indexer/document/DocumentStoreIndexerBase.java Outdated Show resolved Hide resolved
...ain/java/org/apache/jackrabbit/oak/index/indexer/document/indexstore/IndexStoreMetadata.java Outdated Show resolved Hide resolved
.../org/apache/jackrabbit/oak/index/indexer/document/indexstore/IndexStoreSortStrategyBase.java Outdated Show resolved Hide resolved
.../org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileNodeStoreBuilderTest.java Outdated Show resolved Hide resolved
...a/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/PipelinedStrategy.java Outdated Show resolved Hide resolved
...g/apache/jackrabbit/oak/index/indexer/document/incrementalstore/IncrementalStoreBuilder.java Outdated Show resolved Hide resolved
...g/apache/jackrabbit/oak/index/indexer/document/incrementalstore/IncrementalStoreBuilder.java Outdated Show resolved Hide resolved
...he/jackrabbit/oak/index/indexer/document/incrementalstore/MergeIncrementalFlatFileStore.java Outdated Show resolved Hide resolved
...he/jackrabbit/oak/index/indexer/document/incrementalstore/MergeIncrementalFlatFileStore.java Outdated Show resolved Hide resolved
.../java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/MergeIncrementalFFSTest.java Outdated Show resolved Hide resolved
thomasmueller
thomasmueller requested changes Sep 18, 2023
View reviewed changes
Copy link
Member

@thomasmueller thomasmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Partial review)

...java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileNodeStoreBuilder.java Outdated Show resolved Hide resolved
...java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileNodeStoreBuilder.java Show resolved Hide resolved
...ain/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/NodeStateEntryWriter.java Outdated Show resolved Hide resolved
...ain/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/NodeStateEntryWriter.java Outdated Show resolved Hide resolved
thomasmueller
thomasmueller reviewed Sep 20, 2023
View reviewed changes
Copy link
Member

@thomasmueller thomasmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what is the test coverage of the new classes... do you have any numbers?

...he/jackrabbit/oak/index/indexer/document/flatfile/MultithreadedTraverseWithSortStrategy.java Show resolved Hide resolved
...ain/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/StoreAndSortStrategy.java Outdated Show resolved Hide resolved
@tihom88
Copy link
Contributor Author

tihom88 commented Sep 20, 2023

I wonder what is the test coverage of the new classes... do you have any numbers?

Currently we have unit test around Merge and an IT IncrementalStoreIT. I will be adding few more test cases mainly around the the NodeStateWrite getParts.

@tihom88 tihom88 merged commit 8752a2e into apache:trunk Sep 26, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfsantos nfsantos nfsantos left review comments

@amit-jain amit-jain amit-jain left review comments

@steffenvan steffenvan steffenvan left review comments

@fabriziofortino fabriziofortino fabriziofortino approved these changes

@nit0906 nit0906 nit0906 approved these changes

@thomasmueller thomasmueller Awaiting requested review from thomasmueller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@tihom88 @nfsantos @thomasmueller @fabriziofortino @amit-jain @nit0906 @steffenvan