Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAK-10526 : test to reproduce split doc GC with referenced revisions #1184

Merged
merged 3 commits into from
Nov 6, 2023
Merged

OAK-10526 : test to reproduce split doc GC with referenced revisions #1184

merged 3 commits into from
Nov 6, 2023

Conversation

stefan-egli
Copy link
Contributor

No description provided.

Joscorbe
Joscorbe approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@Joscorbe Joscorbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to review the test carefully to fully understand it, but I think it correctly tests the underlying issue.
+1

mreutegg
mreutegg reviewed Nov 2, 2023
View reviewed changes
Copy link
Contributor

@mreutegg mreutegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test looks good to me. See suggested changes that made it a bit easier for me to create a mental model of the timeline: #1185

@stefan-egli
Merge pull request #1185 from mreutegg/OAK-10526-test-1
fedd147 
OAK-10526 : test to reproduce split doc GC with referenced revisions
@stefan-egli
Copy link
Contributor Author

Merged #1185

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@stefan-egli stefan-egli merged commit 9f8b7d8 into trunk Nov 6, 2023
3 of 4 checks passed
rishabhdaim pushed a commit that referenced this pull request Nov 22, 2023
@stefan-egli @mreutegg
OAK-10526 : test to reproduce split doc GC with referenced revisions (#…
2be84ea 
…1184)

* OAK-10526 : test to reproduce split doc GC with referenced revisions

* OAK-10526 : test to reproduce split doc GC with referenced revisions

Suggested changes to test

---------

Co-authored-by: Marcel Reutegger <marcel.reutegger@gmail.com>
rishabhdaim pushed a commit that referenced this pull request Jan 25, 2024
@stefan-egli @mreutegg
OAK-10526 : test to reproduce split doc GC with referenced revisions (#…
c206c66 
…1184)

* OAK-10526 : test to reproduce split doc GC with referenced revisions

* OAK-10526 : test to reproduce split doc GC with referenced revisions

Suggested changes to test

---------

Co-authored-by: Marcel Reutegger <marcel.reutegger@gmail.com>
rishabhdaim pushed a commit that referenced this pull request Mar 15, 2024
@stefan-egli @mreutegg
OAK-10526 : test to reproduce split doc GC with referenced revisions (#…
b804a93 
…1184)

* OAK-10526 : test to reproduce split doc GC with referenced revisions

* OAK-10526 : test to reproduce split doc GC with referenced revisions

Suggested changes to test

---------

Co-authored-by: Marcel Reutegger <marcel.reutegger@gmail.com>
rishabhdaim pushed a commit that referenced this pull request Mar 15, 2024
@stefan-egli @mreutegg
OAK-10526 : test to reproduce split doc GC with referenced revisions (#…
c4a8731 
…1184)

* OAK-10526 : test to reproduce split doc GC with referenced revisions

* OAK-10526 : test to reproduce split doc GC with referenced revisions

Suggested changes to test

---------

Co-authored-by: Marcel Reutegger <marcel.reutegger@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mreutegg mreutegg mreutegg left review comments

@Joscorbe Joscorbe Joscorbe approved these changes

@rishabhdaim rishabhdaim Awaiting requested review from rishabhdaim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@stefan-egli @mreutegg @Joscorbe