Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAK-10382 : added flatfile command to the project #1223

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

stefan-egli
Copy link
Contributor

No description provided.

Copy link

sonarcloud bot commented Nov 28, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

81.2% 81.2% Coverage
11.0% 11.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@stefan-egli
Copy link
Contributor Author

The sonar warning is about

Failed condition 11.0% 11.0% Duplicated Lines (%) on New Code (is greater than 3%)

which I would argue are fine in this oak-run context. To avoid this duplication would mean to restructure oak-run commands and introduce base classes and I'm not sure that is helping much in this case.

Copy link
Member

@Joscorbe Joscorbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@stefan-egli stefan-egli merged commit 38caff7 into trunk Nov 28, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants