Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAK-8466 : Old inactive clusterIds may trigger expensive recovery #134

Closed
wants to merge 10,000 commits into from
Closed

OAK-8466 : Old inactive clusterIds may trigger expensive recovery #134

wants to merge 10,000 commits into from

Conversation

Vinod-holani
Copy link

  1. Updated lastRev just before running sweep

  2. Updated test case due to this as lastRev is incremented by 1

reschke and others added 30 commits April 24, 2019 14:19
@reschke
OAK-8257: RDBDocumentStore: improve trace logging of batch operations
94ba8cb 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858053 13f79535-47bb-0310-9956-ffa450edef68
@stillalex
OAK-8234 Reduce object allocation in PermissionProviderImpl for admin…
5f7a67e 
… sessions

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858054 13f79535-47bb-0310-9956-ffa450edef68
@anchela
OAK-8234 : adding missing annotations with AllPermissionProviderImpl
11e70f5 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858061 13f79535-47bb-0310-9956-ffa450edef68
@anchela
OAK-8276 : OR-CompositeTreePermission.grantsPermission should loop ov…
9e3b4e0 
…er aggregates of supported permissions

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858099 13f79535-47bb-0310-9956-ffa450edef68
@mreutegg
OAK-8277: Run tests on travis-ci.org on MongoDB 4.0.x
65b3ef5 
Update to MongoDB 4.0.9

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858123 13f79535-47bb-0310-9956-ffa450edef68
@mreutegg
OAK-8277: Run tests on travis-ci.org on MongoDB 4.0.x
cde9dbb 
Update documentation about recommended MongoDB version

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858124 13f79535-47bb-0310-9956-ffa450edef68
@reschke
OAK-8273: RDBDocumentStore: createOrUpdate with less than 3 ops subop…
bf16609 
…timal

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858139 13f79535-47bb-0310-9956-ffa450edef68
@anchela
OAK-8281 : Improve coverage for org.apache.jackrabbit.oak.security.au…
79ce670 
…thorization.composite

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858190 13f79535-47bb-0310-9956-ffa450edef68
@reschke
OAK-8190: Javadoc fixes
2a7d77e 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858194 13f79535-47bb-0310-9956-ffa450edef68
OAK-8278: RDBDataSourceFactory.CloseableDataSource doesn't implement …
7ba4b11 
…java.sql.Wrapper correctly

CloseableDataSource now wraps it's internal DataSource instance.


git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858195 13f79535-47bb-0310-9956-ffa450edef68
@anchela
OAK-8263 : Simplify PermissionEntry.compareTo
7b2fce3 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858196 13f79535-47bb-0310-9956-ffa450edef68
OAK-8278: RDBDataSourceFactory.CloseableDataSource doesn't implement …
a2a987c 
…java.sql.Wrapper correctly

Fixed implementation to respect Wrapper contract.


git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858197 13f79535-47bb-0310-9956-ffa450edef68
@anchela
OAK-8266 : Redundant check for existing tree in CompiledPermissionImp…
0cd3f54 
…l.buildVersionDelegatee

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858199 13f79535-47bb-0310-9956-ffa450edef68
@reschke
OAK-8286: Update jetbrains nullability annotations to 17.0.0
4bd78e6 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858385 13f79535-47bb-0310-9956-ffa450edef68
@reschke
OAK-8149: java 12 javadoc fails with 'unknown tag' for OSGi version a…
9b2b79e 
…nnotations in package-info - added workaround to javadoc plugin config

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858407 13f79535-47bb-0310-9956-ffa450edef68
@anchela
OAK-8269 : Improve readability of CompositePermissionProvider and Com…
43c3bcf 
…positeTreePermission

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858410 13f79535-47bb-0310-9956-ffa450edef68
@anchela
OAK-8284 : Improvements to EntryPredicate
e585856 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858411 13f79535-47bb-0310-9956-ffa450edef68
@reschke
OAK-8288: fix javadoc:javadoc for jdk >= 13
e731dff 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858414 13f79535-47bb-0310-9956-ffa450edef68
@reschke
OAK-8288: fix javadoc:javadoc for jdk >= 13
1a2fbaa 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858415 13f79535-47bb-0310-9956-ffa450edef68
@reschke
OAK-8288: fix javadoc:javadoc for jdk >= 13
690f4d9 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858416 13f79535-47bb-0310-9956-ffa450edef68
@reschke
OAK-8288: fix javadoc:javadoc for jdk >= 13
30e7ab9 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858417 13f79535-47bb-0310-9956-ffa450edef68
@reschke
OAK-8288: fix javadoc:javadoc for jdk >= 13
b9e3004 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858418 13f79535-47bb-0310-9956-ffa450edef68
@reschke
OAK-8290: Update org.apache.felix.framework for jdk13
f962873 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858424 13f79535-47bb-0310-9956-ffa450edef68
@reschke
OAK-8288: fix javadoc:javadoc for jdk >= 13 - changes reverted (see t…
bdd5ad9 
…icket)

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858442 13f79535-47bb-0310-9956-ffa450edef68
@stillalex
OAK-8249 NodeImpl#isNodeType could load mixin info lazily
2e7b6ab 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858530 13f79535-47bb-0310-9956-ffa450edef68
@anchela
OAK-8293 : PrincipalProviderImpl.findPrincipals my return null values…
399efd4 
… in result iterator

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858534 13f79535-47bb-0310-9956-ffa450edef68
@anchela
OAK-8262 : CompiledPermissionImpl returns wrong type of TreePermissio…
68e4282 
…n for child of permission store

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858538 13f79535-47bb-0310-9956-ffa450edef68
@catholicon
OAK-8166: Index definition with orderable property definitions with a…
bf2adfc 
…nd without functions breaks index

Committing fix contributed by Nitin Gupta (@nitigup).

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858544 13f79535-47bb-0310-9956-ffa450edef68
@reschke
OAK-8296: DocumentNodeStoreBranchesTest uses javax.annotation.Nonnull
f172ce3 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858571 13f79535-47bb-0310-9956-ffa450edef68
@reschke
OAK-7902: Update osgi-mock to 2.3.10
46cde5e 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1858578 13f79535-47bb-0310-9956-ffa450edef68
mreutegg and others added 26 commits July 8, 2019 13:11
@mreutegg
OAK-8449: LastRev check/fix in DocumentNodeStore MBean
f60e585 
Patch provided by Vinod Holani.

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1862746 13f79535-47bb-0310-9956-ffa450edef68
@reschke
OAK-8448: VersionGC may get stuck at 60s scope
eb79e85 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1862806 13f79535-47bb-0310-9956-ffa450edef68
@reschke
OAK-8453: Refactor VersionGarbageCollector to extract Recommendations…
56e3337 
… class - use separate logger

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1862817 13f79535-47bb-0310-9956-ffa450edef68
@thomasmueller
OAK-8455 Memory Node store implementation of PropertyState throws Exc…
bebce56 
…eption that is not in line with the API documentation

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1862850 13f79535-47bb-0310-9956-ffa450edef68
@reschke
OAK-8467: broken version numbers for oak-doc and oak-doc-railroad-macro
4e62576 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1862862 13f79535-47bb-0310-9956-ffa450edef68
@reschke
OAK-8468: document RDB specific log messages
09b130e 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1862863 13f79535-47bb-0310-9956-ffa450edef68
@thomasmueller
OAK-7254 Indexes with excludedPaths, or includedPaths should not be p…
abef865 
…icked for queries without path

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1862879 13f79535-47bb-0310-9956-ffa450edef68
@mreutegg
OAK-8472: Typo in oak-run console refresh command help
37dad5b 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1862881 13f79535-47bb-0310-9956-ffa450edef68
@mreutegg
OAK-8473: oak-run recovery fails with custom blob store
256368d 
Add ignored test

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1862908 13f79535-47bb-0310-9956-ffa450edef68
OAK-8466 : Old inactive clusterIds may trigger expensive recovery
35e9455 
1. Updated lastRev just before running sweep

2. Updated test case due to this as lastRev is incremented by 1
@mreutegg
OAK-8473: oak-run recovery fails with custom blob store
be7212c 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1862909 13f79535-47bb-0310-9956-ffa450edef68
OAK-8466 : Updating comments and test case
f45202d
@mreutegg
OAK-8474: oak-run revisions fails with custom blob store
cf27792 
Add ignored test

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1862915 13f79535-47bb-0310-9956-ffa450edef68
@mreutegg
OAK-8474: oak-run revisions fails with custom blob store
03e19c3 
Add tests for all sub-commands

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1862916 13f79535-47bb-0310-9956-ffa450edef68
@mreutegg
OAK-8474: oak-run revisions fails with custom blob store
07c78d8 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1862917 13f79535-47bb-0310-9956-ffa450edef68
@reschke
OAK-8476: RDBVersionGCSupport returns incorrect value for "oldest del…
04c2cef 
…eted document" - add ignored test

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1862926 13f79535-47bb-0310-9956-ffa450edef68
@reschke
OAK-8476: RDBVersionGCSupport returns incorrect value for "oldest del…
c944866 
…eted document"

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1862927 13f79535-47bb-0310-9956-ffa450edef68
@reschke
OAK-8478: remove unneeded javadoc plugin version number from reactor pom
2bc6f93 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1862976 13f79535-47bb-0310-9956-ffa450edef68
@reschke
OAK-8479: update rat plugin to 0.13
4db39bb 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1862977 13f79535-47bb-0310-9956-ffa450edef68
@reschke
OAK-8481: RDB*Store: update postgresql jdbc driver reference to 42.4.6
64db5fa 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1863076 13f79535-47bb-0310-9956-ffa450edef68
@reschke
OAK-8483: RDB*Store: update mysql jdbc driver reference to 8.0.16
9a4d8f1 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1863081 13f79535-47bb-0310-9956-ffa450edef68
@reschke
OAK-8485: RDB*Store: update mssql jdbc driver reference to 8.0.16
aeeb47d 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1863086 13f79535-47bb-0310-9956-ffa450edef68
OAK-8466 : Updating maybeRefreshHeadRevision method to update
bf9f56c 
periodically lastRev on root node, added test case for the same
@vholani
Merge branch 'upstream-trunk' into OAK-8466
36722f7
@mreutegg
OAK-8466: Old inactive clusterIds may trigger expensive recovery
ef6d59c 
- Simplified the test a bit
- Avoided read of root document by reading the _lastRev via the root state's getLastRevision()
- Putting the new head revision into unsavedLastRevisions is already done in DocumentNodeStore.done() within the headOfQueue() method -> c.applyLastRevUpdates(). However, this only works when the root path is considered modified. Made Commit.markChanged() package private for this purpose and used it in maybeRefreshHeadRevision().
@Vinod-holani
Merge pull request #1 from mreutegg/OAK-8466
28d947a 
OAK-8466: Old inactive clusterIds may trigger expensive recovery
@github-actions
Copy link

This PR is stale because it has been open 24 months with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Nov 22, 2022
@github-actions github-actions bot closed this Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone