OAK-10771 - Add disk cache size stats and issue warning if evicted segment has zero length #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smiroslav
reviewed
May 8, 2024
| return; | ||
| } | ||
| long cacheSizeAfter = cacheSize.addAndGet(-length); | ||
| diskCacheIOMonitor.updateCacheSize(cacheSizeAfter, directory.length()); |
There was a problem hiding this comment.
https://docs.oracle.com/javase/8/docs/api/java/io/File.html#length--
API docs says that File.length returns unspecified value for directories.
smiroslav
reviewed
May 8, 2024
| cacheSize.addAndGet(-segment.length()); | ||
| long length = segment.length(); | ||
| if (length == 0) { | ||
| if (logger.isDebugEnabled()) { |
There was a problem hiding this comment.
Why both debug and warn are needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The persistent disk cache computes its size internally by adding/subtracting the size of added/purged segments. We would like to be able to see if that computation is correct, by having both the computed size and the effective size on disk in the metrics.
The background for this is that in a few rare instances, the disk cache evicted too many items (down to almost zero) instead of the expected 65% of its max size.
Also we want to make sure that no evictions happen on items that have a length of zero. We're not sure if that happens or not, so the change is to refuse eviction in that case and log a warning instead.