OAK-8633: Add warn logs if we add/update a string property larger tha… #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er package git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860234 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860235 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860236 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860237 13f79535-47bb-0310-9956-ffa450edef68
…mapping git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860247 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860250 13f79535-47bb-0310-9956-ffa450edef68
…er package git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860253 13f79535-47bb-0310-9956-ffa450edef68
…eption git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860254 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860270 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860278 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860280 13f79535-47bb-0310-9956-ffa450edef68
…p from ID and tree git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860319 13f79535-47bb-0310-9956-ffa450edef68
…consistency git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860328 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860329 13f79535-47bb-0310-9956-ffa450edef68
…hould never modify persistence - add ignored test git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860330 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860338 13f79535-47bb-0310-9956-ffa450edef68
…ix javadoc) git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860339 13f79535-47bb-0310-9956-ffa450edef68
…roupTree git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860349 13f79535-47bb-0310-9956-ffa450edef68
…wToPrincipal, EveryonePredicate git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860351 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860352 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860355 13f79535-47bb-0310-9956-ffa450edef68
Clarify content model git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860356 13f79535-47bb-0310-9956-ffa450edef68
…nstance before "build()" git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860393 13f79535-47bb-0310-9956-ffa450edef68
…hould never modify persistence git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860442 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860548 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860549 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860550 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860562 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860564 13f79535-47bb-0310-9956-ffa450edef68
…mand git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1860565 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1865614 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1865615 13f79535-47bb-0310-9956-ffa450edef68
Contribution by José Andrés Cordero BenÃtez. git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1865623 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1865630 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1865631 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1865654 13f79535-47bb-0310-9956-ffa450edef68
Apply patch provided by José Andrés Cordero Benítez git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1865688 13f79535-47bb-0310-9956-ffa450edef68
…' profile for CI testing (reverted r1863979) git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1865691 13f79535-47bb-0310-9956-ffa450edef68
…doc generation because of conflicting Lucene versions in class path git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1865693 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1865752 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1865795 13f79535-47bb-0310-9956-ffa450edef68
…rd() calls git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1865859 13f79535-47bb-0310-9956-ffa450edef68
…load URI Add a new method #isInlined to Blob class to check if the external blob is id inlined git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1865962 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1865972 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1865974 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1865986 13f79535-47bb-0310-9956-ffa450edef68
OAK-8552: Minimize network calls required when creating a direct download URI Add a new method #isInlined to Blob class to check if the external blob is id inlined git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1866022 13f79535-47bb-0310-9956-ffa450edef68
- Add a micro-benchmark for Binary#getUri git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1866023 13f79535-47bb-0310-9956-ffa450edef68
…ss included in xml (initial-pw-change) - cleanup imports in test class git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1866037 13f79535-47bb-0310-9956-ffa450edef68
…sts, one of which currently ignored git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1866039 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1866041 13f79535-47bb-0310-9956-ffa450edef68
…generation This change adds a new optional configuration parameter for AzureDataStore and S3DataStore. The new parameter, named "presignedHttpDownloadURIVerifyExists", has a default value of true which means the createHttpDownloadURI() method will ensure the requested blob exists in blob storage before creating the signed download URI. If this parameter is set to false, the exists check will be skipped, resulting in higher signed download URI generation performance but potentially returning a URI to a nonexistent blob in some cases (see OAK-7998). git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1866044 13f79535-47bb-0310-9956-ffa450edef68
This change allows for specific monitoring of specific named loggers that indicate where cloud data stores are streaming bytes to or from cloud storage. Useful for instances that are trying to identify where upload or download streaming through the repository is taking place for those that are attempting to replace such activity with direct binary access in clients. git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1866061 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1866080 13f79535-47bb-0310-9956-ffa450edef68
| @@ -1379,6 +1380,11 @@ private Property internalSetProperty( | |||
| final String oakName = getOakPathOrThrow(checkNotNull(jcrName)); | |||
| final PropertyState state = createSingleState( | |||
| oakName, value, Type.fromTag(value.getType(), false)); | |||
| long maxStringPropertyLength = sessionContext.getRepository().getDescriptorValue(RepositoryImpl.MAX_STRING_PROPERTY_SIZE).getLong(); | |||
There was a problem hiding this comment.
internalSetProperty is called very, very often. It is performance critical.
The method call getDescriptorValue is relatively slow. Instead, the value should be stored in the session context or the repository as a field, so it is faster to retrieve the value.
Also, the value is only needed for properties of type "string". So this line can be moved inside the "if (type == "string")".
| @@ -1414,7 +1420,13 @@ private Property internalSetProperty( | |||
| if (values.length > MV_PROPERTY_WARN_THRESHOLD) { | |||
| LOG.warn("Large multi valued property [{}/{}] detected ({} values).",dlg.getPath(), jcrName, values.length); | |||
| } | |||
|
|
|||
| long maxStringPropertyLength = sessionContext.getRepository().getDescriptorValue(RepositoryImpl.MAX_STRING_PROPERTY_SIZE).getLong(); | |||
|
This PR is stale because it has been open 24 months with no activity. Remove stale label or comment or this will be closed in 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n 100KB