Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAK-9497 enable logging of Apache DS through Logback during tests and set groups without JNDI LDAP client #327

Merged
merged 2 commits into from Jul 19, 2021

Conversation

kwin
Copy link
Member

@kwin kwin commented Jul 17, 2021

No description provided.

@kwin kwin requested a review from anchela July 17, 2021 16:44
get rid of JNDI LDAP client for set up work
@kwin kwin requested review from mreutegg and mbaedke July 19, 2021 07:54
@kwin kwin changed the title OAK-9497 enable logging of Apache DS through Logback during tests OAK-9497 enable logging of Apache DS through Logback during tests and set groups without JNDI LDAP client Jul 19, 2021
Copy link
Contributor

@mreutegg mreutegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'm not too familiar with this part of the code.

Code changes are tests only and they pass.

@kwin kwin merged commit cda78f8 into apache:trunk Jul 19, 2021
@kwin kwin deleted the bugfix/OAK-9497-fix-logging branch July 19, 2021 13:56
Joscorbe pushed a commit to Joscorbe/jackrabbit-oak that referenced this pull request Sep 3, 2021
enable logging of Apache DS through Logback during tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants