OAK-9654 : more logging for a RuntimeException #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mreutegg
reviewed
Jan 6, 2022
Comment on lines
155
to
157
| LoggerFactory.getLogger(getClass()).error("resolve: RuntimeException with " + | ||
| changeRevision + " - " + value, re); | ||
| throw re; |
There was a problem hiding this comment.
How about turning this into a warn message and not re-throw the exception? I understand the issue is probably with Guava because both key and value are non-null. Guavas LocalCache.put() even checks this.
There was a problem hiding this comment.
Good point, it probably doesn't matter if that put fails - so a rethrow isnt strictly necessary.
Changed that now here
mreutegg
approved these changes
Jan 6, 2022
|
thx. yes, jira ticket is updated now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus an almost forgotten minor cleanup on /Jenkinsfile