Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAK-9665 | Unparseable date property causes entire node to fail indexing #477

Merged
merged 6 commits into from Jan 31, 2022
Merged

OAK-9665 | Unparseable date property causes entire node to fail indexing #477

merged 6 commits into from Jan 31, 2022

Conversation

nit0906
Copy link
Contributor

@nit0906 nit0906 commented Jan 30, 2022

No description provided.

fabriziofortino
fabriziofortino approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@fabriziofortino fabriziofortino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic is sound. I have just left a few comments here and there for possible improvements.

oak-core/src/test/java/org/apache/jackrabbit/oak/query/AbstractQueryTest.java Outdated Show resolved Hide resolved
oak-core/src/test/java/org/apache/jackrabbit/oak/query/AbstractQueryTest.java Outdated Show resolved Hide resolved
oak-core/src/test/java/org/apache/jackrabbit/oak/query/AbstractQueryTest.java Outdated Show resolved Hide resolved
oak-core/src/test/java/org/apache/jackrabbit/oak/query/AbstractQueryTest.java Outdated Show resolved Hide resolved
...rc/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticDocumentMaker.java Outdated Show resolved Hide resolved
...rc/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticDocumentMaker.java Outdated Show resolved Hide resolved
oak-search/src/test/java/org/apache/jackrabbit/oak/plugins/index/IndexQueryCommonTest.java Outdated Show resolved Hide resolved
oak-search/src/test/java/org/apache/jackrabbit/oak/plugins/index/IndexQueryCommonTest.java Outdated Show resolved Hide resolved
@nit0906
Copy link
Contributor Author

nit0906 commented Jan 31, 2022

thanks @fabriziofortino - made changes as per the suggested comments.

@nit0906 nit0906 merged commit 85c7f00 into apache:trunk Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziofortino fabriziofortino fabriziofortino approved these changes

@thomasmueller thomasmueller Awaiting requested review from thomasmueller

@averma21 averma21 Awaiting requested review from averma21

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@nit0906 @fabriziofortino