OAK-9683 Bump elasticsearch version to 7.16.3 #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziofortino
requested changes
Feb 3, 2022
There was a problem hiding this comment.
Good work overall!
There are a few changes needed:
oak-run-elasticdoes not compile because of a size enforcement in the pom. It seems the new Elastic version it's a bit bigger. You need to increase the enforcer from 98MB to 102MB https://github.com/apache/jackrabbit-oak/blob/trunk/oak-run-elastic/pom.xml#L36-L40- the elastiknn test fails because there was a name change from
angulartocosinein a recent version. Just change the expected value tocosine. - the
ElasticIndexProviderServiceTestfails because something has changed in the Elastic client exception handling: a RuntimeException is returned instead of an IOException. Just change the type toExceptionhere https://github.com/apache/jackrabbit-oak/blob/trunk/oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticConnection.java#L129
.../java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticBulkProcessorHandler.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following tests are not yet successfully executed:
ElasticIndexProviderServieTest.defaultSetup
ElasticSimilarQuesryTest.vectorSimilarityElastiknnIndexConfiguration <--- expected angular but was cosine.