Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAK-9687: expose additional elastic metrics #487

Merged
merged 8 commits into from Feb 11, 2022
Merged

OAK-9687: expose additional elastic metrics #487

merged 8 commits into from Feb 11, 2022

Conversation

fabriziofortino
Copy link
Contributor

  • revisited existing metrics adding index reference (that can be translated to labels)
  • added new metrics on number of docs and size
  • refactoring to improve code reuse

nit0906
nit0906 approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@nit0906 nit0906 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , just a couple of nitpicks.

@fabriziofortino fabriziofortino merged commit dfefb61 into apache:trunk Feb 11, 2022
@fabriziofortino fabriziofortino deleted the OAK-9687 branch February 11, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasmueller thomasmueller thomasmueller approved these changes

@nit0906 nit0906 nit0906 approved these changes

@averma21 averma21 Awaiting requested review from averma21

@tihom88 tihom88 Awaiting requested review from tihom88

Assignees
No one assigned
Labels
indexing
Projects
None yet
Milestone
No milestone
3 participants
@fabriziofortino @thomasmueller @nit0906