Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAK-9755 | Lucene metrics using labels #565

Merged
merged 8 commits into from May 12, 2022
Merged

OAK-9755 | Lucene metrics using labels #565

merged 8 commits into from May 12, 2022

Conversation

nit0906
Copy link
Contributor

@nit0906 nit0906 commented May 11, 2022

  • Introducing labels in lucene jmx metrics

fabriziofortino
fabriziofortino approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@fabriziofortino fabriziofortino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...stic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticMetricHandler.java Outdated Show resolved Hide resolved
oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/hybrid/NRTIndex.java Outdated Show resolved Hide resolved
@nit0906
Copy link
Contributor Author

nit0906 commented May 11, 2022

@fabriziofortino - I added another commit to handle the query duration metric as well - now all of the available metrics are moved to ones using labels.

fabriziofortino
fabriziofortino approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@fabriziofortino fabriziofortino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just spot a possible improvement

oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/metric/StatsProviderUtil.java Outdated Show resolved Hide resolved
@nit0906 nit0906 merged commit b213b46 into apache:trunk May 12, 2022
AngelaFabregues pushed a commit to AngelaFabregues/jackrabbit-oak that referenced this pull request May 16, 2022
@angelafabreguesv
Merge branch 'trunk' of https://github.com/AngelaFabregues/jackrabbit…
bf37370 
…-oak into OAK-9686

* 'trunk' of https://github.com/AngelaFabregues/jackrabbit-oak:
  OAK-9755 | Lucene metrics using labels (apache#565)
  change to info level
  remove duplicate
  fix Path Predicate
  OAK-9758 error out if tika dependencies are missing and improve logging to log warning instead of debug silently
AngelaFabregues added a commit to AngelaFabregues/jackrabbit-oak that referenced this pull request May 17, 2022
@AngelaFabregues
Merge branch 'trunk' of https://github.com/AngelaFabregues/jackrabbit…
497020e 
…-oak into OAK-9686

* 'trunk' of https://github.com/AngelaFabregues/jackrabbit-oak:
  OAK-9755 | Lucene metrics using labels (apache#565)
  change to info level
  remove duplicate
  fix Path Predicate
  OAK-9758 error out if tika dependencies are missing and improve logging to log warning instead of debug silently
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasmueller thomasmueller thomasmueller approved these changes

@fabriziofortino fabriziofortino fabriziofortino approved these changes

@tihom88 tihom88 Awaiting requested review from tihom88

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nit0906 @thomasmueller @fabriziofortino