OAK-9896 - Running unit-tests in IntelliJ dos not work #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwin
reviewed
Aug 22, 2022
| @@ -1316,5 +1297,53 @@ | |||
| </pluginManagement> | |||
| </build> | |||
| </profile> | |||
| <profile> | |||
| <id>intellij-build-workaround</id> | |||
There was a problem hiding this comment.
I find it a bit nasty that this workaround profile is actually containing the default configuration when it is not running in IntelliJ. Can we rather leave the default in place without any profile, and override only for IntelliJ (with this profile)?
There was a problem hiding this comment.
I agree with you in principle. The problem is that I don't know how to remove the _plugin.scr instruction once it's configured. Do you know of a way to achieve that?
There was a problem hiding this comment.
There was a problem hiding this comment.
Thank you for the pointer! Please have a look at the revised change.
jsedding
force-pushed
the
OAK-9896-intellij-build-workaround
branch
from
9aea662
to
7e08cfa
Compare
kwin
reviewed
Aug 22, 2022
oak-parent/pom.xml
Outdated
| <id>intellij-build-workaround</id> | ||
| <!-- workaround for IntelliJ issue https://youtrack.jetbrains.com/issue/IDEA-141732/OSMORC-unable-to-load-bnd-plugin --> | ||
| <!-- IntelliJ does not add the plugin's extra dependency to the plugin's class-path, which causes the build to fail. --> | ||
| <!-- This means unit-tests cannot be run from within the IDE. Adding the relevant configuration only in the absence --> |
There was a problem hiding this comment.
Thank's again :) Should be ok now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.