OAK-9947: upgrade jackson (including databind) to 2.13.4 #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziofortino
requested review from
thomasmueller,
tihom88,
nit0906 and
reschke
joerghoh
approved these changes
Sep 20, 2022
reschke
requested changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original goal of this task was to upgrade jackson-databind since versions before 2.13.0 are affected by CVE-2020-36518.
After upgrading to 2.13.4 some tests in
oak-segment-awswere not working (hung indefinitely).aws-java-sdk-s3uses a less recent version of jackson and it does not work with the latest (it should be upgraded in a separate PR).In general, jackson should not be in the parent pom dependencies otherwise the libraries with transitive dependencies will be forced to use it (and in some cases, it would not work). The parent pom now contains the
jackson.versiononly. Submodules are required to reference it.