Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAK-10051 attach correct artifact #810

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Conversation

kwin
Copy link
Member

@kwin kwin commented Dec 27, 2022

Use the one from m-assembly-p instead of the one from m-jar-p

Use the one from m-assembly-p instead of the one from m-jar-p
@kwin kwin requested a review from reschke December 27, 2022 09:07
@sonarcloud
Copy link

sonarcloud bot commented Dec 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@reschke
Copy link
Contributor

reschke commented Jan 1, 2023

Is there a simple way to test this?

@kwin
Copy link
Member Author

kwin commented Jan 1, 2023

Just execute mvn install on that module and look in the log which artifact is installed in the local repo.

@reschke
Copy link
Contributor

reschke commented Jan 1, 2023

Ah, good point.

Copy link
Contributor

@reschke reschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kwin kwin merged commit af958d3 into trunk Jan 2, 2023
@kwin kwin deleted the bugfix/attach-correct-artifact branch January 2, 2023 08:46
reschke pushed a commit that referenced this pull request Mar 20, 2023
Use the one from m-assembly-p instead of the one from m-jar-p
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants