Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAK-10228 : Explain effect of policies for unknown principals and non-existing paths #915

Merged
merged 1 commit into from May 12, 2023

Conversation

kwin
Copy link
Member

@kwin kwin commented Apr 28, 2023

No description provided.

@kwin kwin requested a review from anchela April 28, 2023 13:23
Copy link
Contributor

@anchela anchela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @kwin , i find the mentioning of 'referential integrity' confusing as this is in JCR world associated with referenceable nodes and properties of type REFERENCE. However, neither path nor principal names properties are of type REFERENCE (or WEAK-REFERENCE) and thus the notion of referential integrity does not apply here.

I agree though that adding a paragraph explaining the behavior in case of removal of nodes and principals is indeed helpful. thanks for taking the time to clarify that.

ps: can we also have a jira ticket associated with the change? as a description you could just link to the dev-list conversation.

@kwin
Copy link
Member Author

kwin commented Apr 28, 2023

@anchela Any proposal for a snappy headline?

@anchela
Copy link
Contributor

anchela commented May 4, 2023

@kwin , not sure if am good at 'snappy'..... having said that i would go with

Unknown principals and non-existing paths
or
Effect with unknown principals and non-existing paths

if you want to elaborate a bit more you could also include (in addition to the mentioning that there is no automatic cleanup):

  • restrictions limit the effect of a given access control entry to certain items which may or may not exist (-> link to restriction extension)
  • creation of new ACEs for non-existing principals is governed by the 'import-behavior' (-> link to import behavior)

does that make sense?

@anchela anchela changed the title Add paragraph on (non-existing) referential integrity of policies OAK-10228 : Explain effect of policies for unknown principals and non-existing paths May 4, 2023
@anchela
Copy link
Contributor

anchela commented May 4, 2023

@kwin , i created a ticket for this change and adjusted the summary. hope that's ok

non-existing paths

Minor cleanup of markdown
@kwin kwin force-pushed the feature/document-referential-integrity branch from e70e908 to f20919b Compare May 4, 2023 17:44
@kwin
Copy link
Member Author

kwin commented May 4, 2023

@anchela I updated this PR accordingly.

Regarding

restrictions limit the effect of a given access control entry to certain items which may or may not exist

This is for me a bit outside the scope of unknown principals/non-existing paths so let us rather tackle separately.

@kwin
Copy link
Member Author

kwin commented May 11, 2023

@anchela Ping, any more feedback? Otherwise I would merge tomorrow.

@kwin kwin merged commit fe23488 into trunk May 12, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants