Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAK-10093 : provided support for SSE Customer Keys for AWS #960

Merged
merged 7 commits into from
Jun 26, 2023

Conversation

rishabhdaim
Copy link
Contributor

No description provided.

Copy link
Contributor

@amit-jain amit-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rishabhdaim rishabhdaim force-pushed the OAK-10093 branch 4 times, most recently from 868912a to 04bcb4b Compare June 8, 2023 10:39
@rishabhdaim
Copy link
Contributor Author

@amit-jain @anchela @mreutegg could you please review the PR, after the new code changes?

@mreutegg
Copy link
Contributor

See also my comment in JIRA about use of customer provided encryption key and direct binary access feature in Oak.

@sonarcloud
Copy link

sonarcloud bot commented Jun 19, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

9.1% 9.1% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Contributor

@mreutegg mreutegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rishabhdaim rishabhdaim merged commit 83b3094 into trunk Jun 26, 2023
2 of 4 checks passed
@rishabhdaim rishabhdaim deleted the OAK-10093 branch June 26, 2023 15:23
rishabhdaim added a commit that referenced this pull request Jun 26, 2023
OAK-10093 : provided support for SSE Customer Keys for AWS
rishabhdaim added a commit that referenced this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants