-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAK-10093 : provided support for SSE Customer Keys for AWS #960
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
868912a
to
04bcb4b
Compare
@amit-jain @anchela @mreutegg could you please review the PR, after the new code changes? |
oak-blob-cloud/src/main/java/org/apache/jackrabbit/oak/blob/cloud/s3/S3Constants.java
Outdated
Show resolved
Hide resolved
oak-blob-cloud/src/main/java/org/apache/jackrabbit/oak/blob/cloud/s3/S3Constants.java
Outdated
Show resolved
Hide resolved
oak-blob-cloud/src/main/java/org/apache/jackrabbit/oak/blob/cloud/s3/S3Constants.java
Outdated
Show resolved
Hide resolved
See also my comment in JIRA about use of customer provided encryption key and direct binary access feature in Oak. |
… base64 encoded 32 bytes SSE_C keys
SonarCloud Quality Gate failed. 0 Bugs 9.1% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
OAK-10093 : provided support for SSE Customer Keys for AWS
No description provided.