OAK-10280: Occasional failure to start docker container #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidate multiple copies of AzuriteDockerRule Skip test when waiting for port or startup message times out
Remember startup exception across multiple instantiations of MongoDockerRule with same configuration
Remember startup exception across multiple instantiations of AzuriteDockerRule with same configuration
jelmini
approved these changes
Jun 9, 2023
| container.waitForPort("10000/tcp"); | ||
| container.waitForLog("Azurite Blob service is successfully listening at http://0.0.0.0:10000"); | ||
| try { | ||
| container.waitForPort("10000/tcp"); |
There was a problem hiding this comment.
Would it make sense to increase the timeout in waitForPort() to prevent tests to be ignored too often, if the origin of the issue is slow Jenkins nodes? The default timeout is 30s and it could be increased to 60s, for example .
There was a problem hiding this comment.
I don't know if the problem is a slow Jenkins. 30 seconds already seems generous to me and the actual problem may be something else. Maybe this could be tackled in another JIRA ticket...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate multiple copies of AzuriteDockerRule
Skip test when waiting for port or startup message times out