JCR-4401: Separate jackrabbit-standalone-components from jackrabbit-standalone #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et Main as protected for downstream
asfgit
pushed a commit
that referenced
this pull request
Oct 7, 2019
…tandalone. This closes #82 from github. git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1855719 13f79535-47bb-0310-9956-ffa450edef68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new submodule, jackrabbit-standalone-components, which contains most of the dependencies and classes and resource, while jackrabbit-standalone includes all of those transitively through jackrabbit-standalone-components.
I've used this, jackrabbit-standalone-components in the new
webdav4provider of Commons VFS. Everything seems working fine now. I made a pull request there for review purpose for now: apache/commons-vfs#52By the way, I've made two changes in the standalone
Mainclass for the cases where unit tests starts a Jackrabbit standalone Main:#runpublic, so unit tests can easily instantiate and start it.#shutdownas public, so unit tests can make a graceful shutdown before JVM shutdown hook takes the place.