MIME4J-283 DecoderUtil performance fix #26
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DecoderUtil currently uses the following regex pattern for rfc2047-encoded words:
"(.*?)=\\?(.+?)\\?(\\w)\\?(.*?)\\?="
First capturing group
(.*?)
is a very expensive regular expression causing next pattern node evaluation on every input character. Because of this decoding of 4 KB input (To:
field with 40-80 recipients) takes up to 200ms on modern CPUs.At the same time, this capturing group used only to store separator text between encoded words. Proposed patch reuses existing
tailIndex
for separator text extraction and same input decoding now takes only 1-2ms.