JAMES-3784 Ease mail repository / event dead letter operation #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibenwa
requested changes
Jun 23, 2022
There was a problem hiding this comment.
What prevents today to have CRON on reprocessing/redelivery is that it is unbounded.
If I have 1 billion entries in there it gonna take a lot of resources to process that.
A rate limit do not really address the concern: that still remains unbounded and we now have a task that takes forever that prevents execution of other task, and the CRON would just add more task in there.
IMO a good old limit is more appropriate/
...common/src/main/java/org/apache/james/modules/ErrorMailRepositoryEmptyHealthCheckModule.java
Show resolved
Hide resolved
...ry-api/src/main/java/org/apache/james/mailrepository/api/MailRepositoryEmptyHealthCheck.java
Outdated
Show resolved
Hide resolved
...ry-api/src/main/java/org/apache/james/mailrepository/api/MailRepositoryEmptyHealthCheck.java
Outdated
Show resolved
Hide resolved
...ry-api/src/main/java/org/apache/james/mailrepository/api/MailRepositoryEmptyHealthCheck.java
Outdated
Show resolved
Hide resolved
...ry-api/src/main/java/org/apache/james/mailrepository/api/MailRepositoryEmptyHealthCheck.java
Outdated
Show resolved
Hide resolved
...ailbox/src/main/java/org/apache/james/webadmin/service/EventDeadLettersRedeliverService.java
Outdated
Show resolved
Hide resolved
...mailrepository/src/main/java/org/apache/james/webadmin/service/ReprocessingAllMailsTask.java
Outdated
Show resolved
Hide resolved
...dmin-mailrepository/src/main/java/org/apache/james/webadmin/service/ReprocessingService.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| private Mono<Task.Result> reprocessAll(Reprocessor reprocessor, MailRepositoryPath path, Configuration configuration, Consumer<MailKey> keyListener) { | ||
| return Flux.fromStream(Throwing.supplier(() -> mailRepositoryStoreService.getRepositories(path))) |
There was a problem hiding this comment.
Any chances this does blocking reads?
...dmin-mailrepository/src/main/java/org/apache/james/webadmin/service/ReprocessingService.java
Outdated
Show resolved
Hide resolved
chibenwa
reviewed
Jun 24, 2022
...ilbox/src/test/java/org/apache/james/webadmin/service/EventDeadLettersRedeliverTaskTest.java
Show resolved
Hide resolved
...repository/src/test/java/org/apache/james/webadmin/service/ReprocessingAllMailsTaskTest.java
Show resolved
Hide resolved
|
vttranlina
changed the title
chibenwa
approved these changes
Jun 28, 2022
...i/src/main/java/org/apache/james/mailrepository/api/EmptyErrorMailRepositoryHealthCheck.java
Outdated
Show resolved
Hide resolved
Arsnael
approved these changes
Jun 28, 2022
vttranlina
force-pushed
the
JAMES_3784
branch
2 times, most recently
from
65a46ff
to
32683f5
Compare
|
Squash fixup & Complete TODO |
|
You can rebase it again (sorry) as I just merged #1049 |
… event task, Reprocessing mail task
…deliver event task, Reprocessing mail task
Arsnael
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.apache.org/jira/projects/JAMES/issues/JAMES-3784