Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAMES-2434 IsFromMailingList matcher #1606

Merged
merged 4 commits into from Jun 26, 2023
Merged

Conversation

Maxxx873
Copy link
Contributor

  • Implemented IsFromMailingList matcher with using AutomaticallySentMailDetector::isMailingList utility. This matcher returns recipients of the mail if the mail is from a mailing list.
  • Fixed IsSingleRecipient matcher - for methods that return an array, prefer returning an empty array over a null value.

Copy link
Contributor

@chibenwa chibenwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 licenses to add but overall thanks for this great contribution!

@@ -0,0 +1,48 @@
package org.apache.james.transport.matchers;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing the compulsary Apache V2 license header comment in this file.

@@ -0,0 +1,50 @@
package org.apache.james.transport.matchers;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing the compulsary Apache V2 license header comment in this file.

@Maxxx873
Copy link
Contributor Author

2 licenses to add but overall thanks for this great contribution!

Thank you for taking the time to review my code. I appreciate your feedback and will use it to improve my work in the future.

Copy link
Contributor

@Arsnael Arsnael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the nice contribution @Maxxx873 , the code looks good to me :)

@Arsnael
Copy link
Contributor

Arsnael commented Jun 26, 2023

20:46:20,494 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (check-style) on project apache-mailet-standard: You have 2 Checkstyle violations. -> [Help 1]

There is some checkstyle issue with your code (we have a maven plugin doing some strict code style checking following this file: https://github.com/apache/james-project/blob/master/checkstyle.xml during the build)

I would guess likely some unused imports in the files in your PR that you added/modified. Please help fixing this :)

@Maxxx873
Copy link
Contributor Author

20:46:20,494 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (check-style) on project apache-mailet-standard: You have 2 Checkstyle violations. -> [Help 1]

There is some checkstyle issue with your code (we have a maven plugin doing some strict code style checking following this file: https://github.com/apache/james-project/blob/master/checkstyle.xml during the build)

I would guess likely some unused imports in the files in your PR that you added/modified. Please help fixing this :)

Sorry, I'm just used to a different import order :)

@Arsnael
Copy link
Contributor

Arsnael commented Jun 26, 2023

Sorry, I'm just used to a different import order :)

No worries :)

@chibenwa chibenwa merged commit 6a73800 into apache:master Jun 26, 2023
1 check passed
thanhbv200585 pushed a commit to thanhbv200585/james-project that referenced this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants