New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JAMES-2434 IsFromMailingList matcher #1606
Conversation
Maxxx873
commented
Jun 23, 2023
- Implemented IsFromMailingList matcher with using AutomaticallySentMailDetector::isMailingList utility. This matcher returns recipients of the mail if the mail is from a mailing list.
- Fixed IsSingleRecipient matcher - for methods that return an array, prefer returning an empty array over a null value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 licenses to add but overall thanks for this great contribution!
@@ -0,0 +1,48 @@ | |||
package org.apache.james.transport.matchers; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are missing the compulsary Apache V2 license header comment in this file.
@@ -0,0 +1,50 @@ | |||
package org.apache.james.transport.matchers; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are missing the compulsary Apache V2 license header comment in this file.
Thank you for taking the time to review my code. I appreciate your feedback and will use it to improve my work in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the nice contribution @Maxxx873 , the code looks good to me :)
There is some checkstyle issue with your code (we have a maven plugin doing some strict code style checking following this file: https://github.com/apache/james-project/blob/master/checkstyle.xml during the build) I would guess likely some unused imports in the files in your PR that you added/modified. Please help fixing this :) |
Sorry, I'm just used to a different import order :) |
No worries :) |