Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAMES-3944 Implement sender rewrites for Forwards #1750

Merged
merged 6 commits into from
Oct 12, 2023

Conversation

chibenwa
Copy link
Contributor

@chibenwa chibenwa commented Oct 9, 2023

No description provided.

@Arsnael
Copy link
Contributor

Arsnael commented Oct 9, 2023

09:26:00,514 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.3.0:check (check-style) on project james-server-guice-common: You have 1 Checkstyle violation. -> [Help 1]

 -> Can be done as an optional
 post-processing step of RRTs

 Which means no configuration changes for users.

This behaviour is the new default behaviour
but can be disabled to fallback to previous
behaviour.
 - Javadoc so also website doc
 - Antora documentation
 - Upgrade instructions
@Arsnael
Copy link
Contributor

Arsnael commented Oct 12, 2023

@chibenwa do you approve of the fixup? :)

Copy link
Contributor Author

@chibenwa chibenwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes approuved

…ntRewriteTable.adoc

Co-authored-by: Trần Hồng Quân <55171818+quantranhong1999@users.noreply.github.com>
@chibenwa chibenwa merged commit 15fe8d1 into apache:master Oct 12, 2023
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants