[PGSQL] ADR on PGSQL flags update concurrency control mechanism #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibenwa
reviewed
Dec 19, 2023
chibenwa
reviewed
Dec 19, 2023
There was a problem hiding this comment.
I want to see explained that we want to avoid wrapping our read-then-write logic into transactions. Transactions are an alternative but they come at a cost: extra locking, coordination cost, needs connection pooling, etc...
I want to see written that we want to re-implement something that a similar semantic with a CRDT (commutative replicated data types) in order to solve concurrency issues. Note that the terms CRDT here is miss-employed as we rely on PGSQL strong concurrency is employed by PG. But the semantic (add - remove items in any order) is.
I think the term CRDT needs to be at least mentioned (under the terms above, which are cautious: similar sementic with a CRDT).
chibenwa
reviewed
Dec 20, 2023
chibenwa
reviewed
Dec 20, 2023
chibenwa
approved these changes
Dec 20, 2023
quantranhong1999
approved these changes
Dec 20, 2023
Arsnael
approved these changes
Dec 20, 2023
Arsnael
pushed a commit
that referenced
this pull request
Jan 11, 2024
Arsnael
pushed a commit
that referenced
this pull request
Jan 11, 2024
Arsnael
pushed a commit
that referenced
this pull request
Mar 20, 2024
Arsnael
pushed a commit
that referenced
this pull request
Apr 16, 2024
Arsnael
pushed a commit
that referenced
this pull request
Jun 27, 2024
Arsnael
pushed a commit
that referenced
this pull request
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve linagora#4956