Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JAMES-3981 Lower log level of closed connections #1983

Merged
merged 3 commits into from
Feb 8, 2024
Merged

JAMES-3981 Lower log level of closed connections #1983

merged 3 commits into from
Feb 8, 2024

Conversation

chibenwa
Copy link
Contributor

@chibenwa chibenwa commented Feb 6, 2024

  • Benign user events
  • That might even be triggered on logout
  • Load balancers might rely on TCP checks triggering such logs upon their health checks, eg HAProxy

@chibenwa
JAMES-3981 Lower log level of closed connections
f1f5353 
 - Benign user events
 - That might even be triggered on logout
 - Load balancers might rely on TCP checks triggering such logs
 upon their health checks, eg HAProxy
@chibenwa chibenwa self-assigned this Feb 6, 2024
@chibenwa
JAMES-3981 Warn upon invalid RCPT
c7350c2 
Not a critical issue but rather a warning
@chibenwa
JAMES-3981 Remove double logs upon closed channels
30ad269 
10:38:19.395 [INFO ] o.a.j.p.n.BasicChannelUpstreamHandler - Connection closed for 169.73.162.80
10:38:19.397 [INFO ] o.a.j.p.n.BasicChannelUpstreamHandler - Unable to process request
java.nio.channels.ClosedChannelException: null
        at org.jboss.netty.handler.stream.ChunkedWriteHandler.discard(ChunkedWriteHandler.java:168)
        at org.jboss.netty.handler.stream.ChunkedWriteHandler.flush(ChunkedWriteHandler.java:192)
        at org.jboss.netty.handler.stream.ChunkedWriteHandler.handleDownstream(ChunkedWriteHandler.java:121)
        at org.jboss.netty.channel.DefaultChannelPipeline.sendDownstream(DefaultChannelPipeline.java:591)
        at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendDownstream(DefaultChannelPipeline.java:784)
        at org.jboss.netty.handler.execution.ExecutionHandler.handleDownstream(ExecutionHandler.java:176)
        at org.jboss.netty.channel.DefaultChannelPipeline.sendDownstream(DefaultChannelPipeline.java:591)
        at org.jboss.netty.channel.DefaultChannelPipeline.sendDownstream(DefaultChannelPipeline.java:582)
        at org.jboss.netty.channel.Channels.write(Channels.java:704)
        at org.jboss.netty.channel.Channels.write(Channels.java:671)
        at org.jboss.netty.channel.AbstractChannel.write(AbstractChannel.java:347)
        at org.apache.james.protocols.netty.NettyProtocolTransport.writeToClient(NettyProtocolTransport.java:104)
        at org.apache.james.protocols.api.AbstractProtocolTransport.writeResponseToClient(AbstractProtocolTransport.java:145)
        at org.apache.james.protocols.api.AbstractProtocolTransport.writeResponse(AbstractProtocolTransport.java:64)
        at org.apache.james.protocols.netty.BasicChannelUpstreamHandler.channelConnected(BasicChannelUpstreamHandler.java:111)
        at org.apache.james.smtpserver.netty.SMTPChannelUpstreamHandler.channelConnected(SMTPChannelUpstreamHandler.java:54)
        at org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:100)
@chibenwa chibenwa mentioned this pull request Feb 7, 2024
Closed
@chibenwa chibenwa merged commit 087a257 into apache:master Feb 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeantil jeantil jeantil approved these changes

@Arsnael Arsnael Arsnael approved these changes

@quantranhong1999 quantranhong1999 quantranhong1999 approved these changes

@vttranlina vttranlina vttranlina approved these changes

Assignees

@chibenwa chibenwa

Labels
enhancement
Projects
None yet
Milestone
No milestone
5 participants
@chibenwa @jeantil @Arsnael @quantranhong1999 @vttranlina