JAMES-4004 [FIX] Allow retries for S3 saves #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vttranlina
force-pushed
the
s3-retries
branch
from
aba5e64
to
422cebd
Compare
Arsnael
changed the title
chibenwa
approved these changes
Feb 19, 2024
Arsnael
approved these changes
Feb 19, 2024
|
https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-2025/1/testReport/ Related. Likely cause we do retries in this case before just throwing an exception, so should adapt those tests |
…- only retry when SdkException
vttranlina
force-pushed
the
s3-retries
branch
from
7a7b9bb
to
a078690
Compare
vttranlina
force-pushed
the
s3-retries
branch
from
a078690
to
911a2e8
Compare
Arsnael
approved these changes
Feb 20, 2024
samiulsami
pushed a commit
to ops-center/james-project
that referenced
this pull request
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue of #2017