JAMES-4008 JMAP - Email/set - Should be able to save a draft with invalid email address #2040
Conversation
…alid email address
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/mail/EmailSet.scala
Show resolved
Hide resolved
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/mail/EmailSet.scala
Show resolved
Hide resolved
…ith invalid email address
updated it in last commit 52ab0e8 the note here is invalid addresses in the "mimeMessage header" (The address in |
| @@ -7507,6 +7507,142 @@ trait EmailSetMethodContract { | |||
|
|
|||
| } | |||
|
|
|||
| @Disabled("Bug of james-mime4j when pasing mimeMessages https://github.com/linagora/james-project/issues/5086") | |||
There was a problem hiding this comment.
Where the problem is? In Email/get?
There was a problem hiding this comment.
Can't we handle the exception in Scala code for the time being?
There was a problem hiding this comment.
yep, Email/get
it returns incorrect to property response
There was a problem hiding this comment.
Can't we handle the exception in Scala code for the time being?
We can handle it by filtering addresses with not value ">"
Is it acceptable?
There was a problem hiding this comment.
As expressed in linagora#5086 (comment) this corner on't happen with Twake mail in practice so it will not be a blocker...
| .inPath("methodResponses[1][1].list") | ||
| .isEqualTo("""[{ | ||
| | "to": [{ | ||
| | "name": "name1", |
There was a problem hiding this comment.
Temporarily disable this test:
Right now the response is
"to": [
{
"name": "name1",
"email": "invalid1"
},
{
"email": ">"
}
]
It is a bug of james-mime4j when parse the message
Detail: linagora#5086
…draft with invalid email address
|
How about by the time we get this fixed we filter in the JMAP stack the lone > email? Not clean but it would do as a temporary fix... |
|
org.apache.james.jmap.rfc8621.memory.MemoryEmailSubmissionSetMethodTest.emailSubmissionSetCanBeChainedAfterEmailSet(GuiceJamesServer) Assertion condition defined as a lambda expression in org.apache.james.jmap.rfc8621.contract.EmailSubmissionSetMethodContract that uses java.lang.String [Node "methodResponses[0][1].ids"] |
|
Related? |
…ith invalid email address
| .`then`(SMono.just(mimeMessage)) | ||
|
|
||
| private def validateMailAddress(headName: String, address: Address): MailAddress = | ||
| Try(new MailAddress(address.toString)) match { |
There was a problem hiding this comment.
Try(new MailAddress(address.getAddress)) match {
There was a problem hiding this comment.
class Address do not have .getAddress method
…alid email address (apache#2040)
jira https://issues.apache.org/jira/browse/JAMES-4008