Add sslMode to require in PostgresqlConnectionConfiguration #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That should be better :) Ready for review |
Default mode on r2dbc lib is disable, which makes our client failing to login in case ssl is required by the postgres db.
chibenwa
reviewed
Mar 13, 2024
...-common/postgres/src/main/java/org/apache/james/backends/postgres/PostgresConfiguration.java
Show resolved
Hide resolved
Arsnael
changed the title
...-common/postgres/src/main/java/org/apache/james/backends/postgres/PostgresConfiguration.java
Outdated
Show resolved
Hide resolved
vttranlina
approved these changes
Mar 14, 2024
quantranhong1999
approved these changes
Mar 14, 2024
Arsnael
added a commit
that referenced
this pull request
Mar 20, 2024
Arsnael
added a commit
that referenced
this pull request
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default is disabled in rd2bc conf, which is an issue when trying to connect to a postgresql db using ssl.
Yes it's dirty, it was to be able to test quickly if I could connect to a postgresql db backed up by ovh service or not.
Result is yes it works :)
Will work on making the sslMode configurable at least.
Would probably be beneficial to make the all ssl configurable in case James is backed by a postgres db hosted internally with specific ssl certs, but we can probably do that later/have a ticket for it.