-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JAMES-2586 Create AttachmentIdFactory #2133
JAMES-2586 Create AttachmentIdFactory #2133
Conversation
|
Any ticket number or tag for this work? |
Should I put JAMES-2586 to this? The purpose of this PR is only refactoring code in master and creating AttachmentIdFactory so that I can implement new AttachmentId for postgres app |
My guess that is OK. |
8fa2ce2
to
a9e9d6a
Compare
No idea why this error occur |
likely just unstable CI |
That's the usual testcontainer bug issue that we have been discussing about so many times already, yeah not related to your PR. I will restart the build |
This PR is to refactor AttachmentID and create AttachmentIdFactory in order to create new AttachmentID implementation in postgresql branch