[FIX] IMAP STATUS should better handle MailboxNotFoundException #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some MUA requests mailboxes that no longer exist nor are subscribed. - Explicit IMAP message - Stacktrace is not necessary in the error message - INFO log Overall computing unused message sizes takes up to 2% of the CPU of the JMAP pods
|
(doubled checked against cyrus for the actual behaviour) |
Arsnael
approved these changes
Mar 27, 2024
| @@ -104,8 +104,8 @@ protected Mono<Void> processRequestReactive(StatusRequest request, ImapSession s | |||
| .then(unsolicitedResponses(session, responder, false)) | |||
| .then(Mono.fromRunnable(() -> okComplete(request, responder))) | |||
| .onErrorResume(MailboxException.class, e -> { | |||
There was a problem hiding this comment.
Should this be explicitly MailboxNotFoundException?
I see lots of sub classes of MailboxException. For the rest, I think we still can fallback to STATUS_FAILED.
There was a problem hiding this comment.
Very right.
Sorry I have been too fast.
quantranhong1999
approved these changes
Mar 28, 2024
Arsnael
approved these changes
Mar 28, 2024
samiulsami
pushed a commit
to ops-center/james-project
that referenced
this pull request
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some MUA requests mailboxes that no longer exist nor are subscribed.