Integration Test for PopulateEmailQueryViewTask with Postgres #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vttranlina
reviewed
Mar 29, 2024
| .configurationFromClasspath() | ||
| .searchConfiguration(SearchConfiguration.scanning()) | ||
| .usersRepository(DEFAULT) | ||
| .eventBusImpl(PostgresJamesConfiguration.EventBusImpl.IN_MEMORY) |
There was a problem hiding this comment.
it will fail when run with rabbitmq eventbus
because TaskEventDTO can't deserialize when "distributed"
// My guess, when tried the same cases
There was a problem hiding this comment.
Good catch I have been focusing on the task itself. Let's check that out
There was a problem hiding this comment.
Actually no there is no distributed task manager in pg, we use the memory one?
There was a problem hiding this comment.
It passes with the rabbitmq extension fyi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which works so now I don't know what to think about what's going on on our staging env...