Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Apply RabbitMQ classic queue version 2 #2243

Merged
merged 3 commits into from
May 16, 2024

Conversation

quantranhong1999
Copy link
Contributor

Claimed to be better than version 1 cf:

Before (all classic queues v1)

Screenshot from 2024-05-13 16-46-30

After (all classic queues v2)

Screenshot from 2024-05-13 16-37-40

Better performance overall (p99 805ms vs 914ms).
SELECT p99 1874ms vs 2049ms
UNSELECT p99 1420ms vs 1755ms

Copy link
Contributor

@chibenwa chibenwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please...

Start a james prior this cange and queue one
Stop it, remove it
And start a james after this change and with queue 2

IE ensure this is not a breaking change.

Thanks!

@quantranhong1999
Copy link
Contributor Author

IE ensure this is not a breaking change.

Sadly this is a breaking change (queue purge is needed).
I would add a configuration to avoid this breaking change e.g. for the older James versions.

@chibenwa
Copy link
Contributor

I would add a configuration to avoid this breaking change e.g. for the older James versions.

+1

And dpcument the breaking change.

Copy link
Contributor

@Arsnael Arsnael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read it

@chibenwa chibenwa merged commit e8aec7e into apache:master May 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants