JAMES-4034 SMTP submission: validate FROM header #2246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will ease channel pool sizing as well as debugging of RabbitMQ channelPool related errors.
Arsnael
approved these changes
May 16, 2024
...ocols-smtp/src/main/java/org/apache/james/smtpserver/SenderAuthIdentifyVerificationHook.java
Outdated
Show resolved
Hide resolved
Comment on lines
+129
to
+134
| private boolean fromDoesNotMatchAuthUser(SMTPSession session, Address from) { | ||
| if (from instanceof InternetAddress internetAddress) { | ||
| try { | ||
| MailAddress mailAddress = new MailAddress(internetAddress.getAddress()); | ||
| return session.getUsername() != null && | ||
| (!fromMatchSessionUser(mailAddress, session) || !belongsToLocalDomain(mailAddress)); |
There was a problem hiding this comment.
Is delegated user supported?
There was a problem hiding this comment.
No need to be supported as
- that's the same validation layer than JMAP
- the authenticated user is identified as the delegated user (impersonnation)
…/smtpserver/SenderAuthIdentifyVerificationHook.java Co-authored-by: Trần Hồng Quân <55171818+quantranhong1999@users.noreply.github.com>
chibenwa
changed the title
quantranhong1999
approved these changes
May 16, 2024
vttranlina
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will ease channel pool sizing as well as debugging of RabbitMQ channelPool related errors.