JAMES-1902 reorganizes blob modules #261
Conversation
| @@ -25,7 +25,7 @@ | |||
| <groupId>org.apache.james</groupId> | |||
| <artifactId>james-server-guice</artifactId> | |||
| <version>3.6.0-SNAPSHOT</version> | |||
| <relativePath>../pom.xml</relativePath> | |||
| <relativePath>../../pom.xml</relativePath> | |||
There was a problem hiding this comment.
Does it makes sense to keep the blob- prefix for folders inside a blob directory? Idem for the guice suffix.
Shouldn't the naming scheme be guice/blob/api ?
There was a problem hiding this comment.
you are right, I wanted to minimize changes but should have included that bit.
There was a problem hiding this comment.
Should we do the same for the queue-xx-guice modules, if any?
There was a problem hiding this comment.
the queue-xxx- modules were already in clean directories ( neither prefix nor suffix)
`src/site/xdoc` recommends to run `mvn com.github.ekryd.sortpom:sortpom-maven-plugin:sort\ -Dsort.keepBlankLines -Dsort.sortDependencies=groupId,artifactId\ -Dsort.nrOfIndentSpace=4 -Dsort.createBackupFile=false\ -Dsort.sortModules=true -Dsort.expandEmptyElements=false\ -Dsort.predefinedSortOrder="recommended_2008_06"` to clean up poms I did it for blob and this commit addresses sort failures for `server/container/guice/queue` pom.xml which were incorrect in the previous PR and the `server/container/guice/queue` pom.xml
jeantil
force-pushed
the
extract-guice-modules
branch
from
ddfaf0b
to
bf32534
Compare
|
Looking to make sure I had the proper sort order in the POM files I stumbled upon sortpom, wich led me to I'm not sure if this recommandation is still applicable because running it returned over 150 incorrectly sorted pom, I applied the fixes to pom files from :
hopefully that's ok |
|
We did not run that for ages, but the rules still applies, and we should do a run... (conflicts likely expected!) You are very right... |
Should it be configured to run automatically on every compile ? to make it easier to sort the modules ? then each new PR can commit the fixed poms it has modified |
And abort the build if needed? => 👍 |
|
I just merged this work. Can we close the PR? |
This PR also removes a couple duplicate dependencies that were present in the POM files.