-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JAMES-3435 Fine grain LWT configuration for the Cassandra mailbox #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chibenwa
commented
Mar 29, 2021
Arsnael
reviewed
Mar 29, 2021
docs/modules/servers/pages/distributed/configure/cassandra.adoc
Outdated
Show resolved
Hide resolved
Arsnael
reviewed
Mar 30, 2021
Arsnael
approved these changes
Mar 31, 2021
…strong write consistency is requested.
As it is not used in write transactions
Let's consider now read-repairs as writes thus requires strong consistency.
As choosing SERIAL or QUORUM upon reads is a shared concern between mailbox and message
Build was 🍏 only squashed fixups. |
If there's some reviewers out there that would like to give some <3 to this work? |
I gave it a cursory look but I haven't dug into mailbox code yet, so I have no idea what i'm looking at which is why I abstained to review further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.