Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JAMES-3429 Add StateMismatch error type and getLatestVersion FilteringManagement #371

Merged
merged 2 commits into from Apr 16, 2021
Merged

JAMES-3429 Add StateMismatch error type and getLatestVersion FilteringManagement #371

merged 2 commits into from Apr 16, 2021

Conversation

quantranhong1999
Copy link
Contributor

No description provided.

@chibenwa
Copy link
Contributor

chibenwa commented Apr 8, 2021

Drop 124644c commit

@quantranhong1999 quantranhong1999 mentioned this pull request Apr 8, 2021
Merged
@quantranhong1999 quantranhong1999 changed the title JAMES-3429 Add StateMismatch error type JAMES-3429 Add StateMismatch error type and getLatestVersion FilteringManagement Apr 9, 2021
@quantranhong1999
Copy link
Contributor Author

quantranhong1999 commented Apr 9, 2021 •
edited

Tests failed on CI:

org.apache.james.jmap.cassandra.filtering.CassandraEventSourcingFilteringManagementTest.setRulesWithIfInStateIsOneWhenNonStateIsDefinedShouldFail{EventStore}
org.apache.james.jmap.cassandra.filtering.CassandraEventSourcingFilteringManagementTest.setRulesWithIfInStateIsInitialWhenAStateIsDefinedShouldFail{EventStore}
org.apache.james.jmap.cassandra.filtering.CassandraEventSourcingFilteringManagementTest.modifyExistingRulesWithWrongCurrentVersionShouldFail{EventStore}

But green on local, please rerun the build

@Arsnael
Copy link
Contributor

Arsnael commented Apr 12, 2021

Build restarted

@quantranhong1999
Copy link
Contributor Author

Don't know why this keep failing, just a rebase and make the ci run again.

@chibenwa chibenwa merged commit f129b69 into apache:master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chibenwa chibenwa chibenwa approved these changes

@Arsnael Arsnael Arsnael approved these changes

@LanKhuat LanKhuat LanKhuat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@quantranhong1999 @chibenwa @Arsnael @LanKhuat