Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JAMES-3618 Support LDAP for JPA guice based apps #553

Merged
merged 1 commit into from Jul 26, 2021
Merged

JAMES-3618 Support LDAP for JPA guice based apps #553

merged 1 commit into from Jul 26, 2021

Conversation

chibenwa
Copy link
Contributor

Includes:

  • JPA App
  • JPA-SMTP App

@chibenwa
JAMES-3618 Support LDAP for JPA guice based apps
845c381 
Includes:
 - JPA App
 - JPA-SMTP App
@chibenwa chibenwa self-assigned this Jul 24, 2021
mbaechler
mbaechler approved these changes Jul 25, 2021
View reviewed changes
Copy link
Member

@mbaechler mbaechler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
I'm wondering if we should split data-api in several parts, it bundles very different concerns.

@chibenwa
Copy link
Contributor Author

I would tend to agree.

At the very least for Sieve and MailRepository related classes. RRT, users and domains can in my opinion be considered some kind of identity components.

@chibenwa chibenwa merged commit e10651e into apache:master Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbaechler mbaechler mbaechler approved these changes

@Arsnael Arsnael Arsnael approved these changes

Assignees

@chibenwa chibenwa

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@chibenwa @mbaechler @Arsnael