JAMES-3544 Attachment refactoring (step 2) #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chibenwa
commented
Aug 9, 2021
•
chibenwa
commented
- Hold messageId within mail table
- Rework JMAP draft to reduce queries related to attachments
- Migration to add messageId to attachment table
- Group reads on the BlobManager - this allows querying only once the message/mailbox context of attachments
chibenwa
commented
Aug 10, 2021
...ation-testing/src/test/java/org/apache/james/jmap/memory/MemorySpamAssassinContractTest.java
Outdated
Show resolved
Hide resolved
chibenwa
commented
Aug 10, 2021
...n-testing/src/test/java/org/apache/james/jmap/memory/MemoryVacationRelayIntegrationTest.java
Outdated
Show resolved
Hide resolved
chibenwa
force-pushed
the
JAMES-3544-refacto-2
branch
from
0f5c9f5
to
47a638a
Compare
chibenwa
force-pushed
the
JAMES-3544-refacto-2
branch
from
47a638a
to
66f65ef
Compare
chibenwa
force-pushed
the
JAMES-3544-refacto-2
branch
from
66f65ef
to
f047b37
Compare
Arsnael
approved these changes
Aug 16, 2021
vttranlina
reviewed
Aug 16, 2021
...ain/java/org/apache/james/mailbox/cassandra/mail/migration/AttachmentMessageIdMigration.java
Show resolved
Hide resolved
chibenwa
force-pushed
the
JAMES-3544-refacto-2
branch
from
f047b37
to
f3a9d22
Compare
|
Force pushed to solve conflict |
chibenwa
force-pushed
the
JAMES-3544-refacto-2
branch
from
f3a9d22
to
858c00e
Compare
In order to simplify the query flow, and reduce the amount on primary key reads when working with attachments when using JMAP, we did add the messageId property to the `attachmentV2` table. Newly stored attachment will then store their corresponding messageId alongside `attachmentV2` and will no longer need to read `messageIdTable`.
This allows dropping a MessageId hack, due to the use of wrong types. Furthermore, this makes a single call for each attachment to the underlying BlobManager, thus fasten things up.
The access rights is done at access time, we can get rid of this double read pattern.
Required for authentication in Thunderbird. Failure to do so will cause issues.
chibenwa
force-pushed
the
JAMES-3544-refacto-2
branch
from
858c00e
to
8c0e784
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.