JAMES-3539 Cassandra implement for PushSubscriptionRepository #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quantranhong1999
force-pushed
the
cassandraPushSubscription
branch
from
92a10a7
to
03facff
Compare
chibenwa
reviewed
Oct 28, 2021
...main/java/org/apache/james/jmap/cassandra/pushsubscription/CassandraPushSubscriptionDAO.java
Outdated
Show resolved
Hide resolved
...va/org/apache/james/jmap/cassandra/pushsubscription/CassandraPushSubscriptionRepository.java
Outdated
Show resolved
Hide resolved
...va/org/apache/james/jmap/cassandra/pushsubscription/CassandraPushSubscriptionRepository.java
Outdated
Show resolved
Hide resolved
...va/org/apache/james/jmap/cassandra/pushsubscription/CassandraPushSubscriptionRepository.java
Outdated
Show resolved
Hide resolved
...va/org/apache/james/jmap/cassandra/pushsubscription/CassandraPushSubscriptionRepository.java
Outdated
Show resolved
Hide resolved
...va/org/apache/james/jmap/cassandra/pushsubscription/CassandraPushSubscriptionRepository.java
Outdated
Show resolved
Hide resolved
...otocols/jmap-rfc-8621/src/test/scala/org/apache/james/jmap/change/TypeStateFactoryTest.scala
Outdated
Show resolved
Hide resolved
...ap-rfc-8621/src/test/scala/org/apache/james/jmap/change/StateChangeEventSerializerTest.scala
Outdated
Show resolved
Hide resolved
...main/java/org/apache/james/jmap/cassandra/pushsubscription/CassandraPushSubscriptionDAO.java
Outdated
Show resolved
Hide resolved
|
Nothing to add... However, I'm trying to understand something here. You marked a bunch of issues as resolved while they are not. Do you mark them while you develop before pushing at the end of the day maybe? :) |
I mark it resolved while I am resolving it just not to confuse which I should resolve left. |
vttranlina
reviewed
Oct 28, 2021
...main/java/org/apache/james/jmap/cassandra/pushsubscription/CassandraPushSubscriptionDAO.java
Outdated
Show resolved
Hide resolved
...va/org/apache/james/jmap/cassandra/pushsubscription/CassandraPushSubscriptionRepository.java
Outdated
Show resolved
Hide resolved
.../org/apache/james/jmap/cassandra/pushsubscription/tables/CassandraPushSubscriptionTable.java
Outdated
Show resolved
Hide resolved
|
WIP: create helper class, optimize time store |
chibenwa
reviewed
Oct 29, 2021
...main/java/org/apache/james/jmap/cassandra/pushsubscription/CassandraPushSubscriptionDAO.java
Outdated
Show resolved
Hide resolved
chibenwa
approved these changes
Oct 29, 2021
We need TypeStateFactory at data-jmap level to parse string (stored in Cassandra) to TypeName
…SubscriptionKeys error
quantranhong1999
force-pushed
the
cassandraPushSubscription
branch
from
24b04b9
to
1e69280
Compare
|
Just a rebase and squash fixups. |
Arsnael
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.