Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JAMES-3539 PushSubscription/set update expires #727

Merged
merged 2 commits into from Nov 10, 2021
Merged

JAMES-3539 PushSubscription/set update expires #727

merged 2 commits into from Nov 10, 2021

Conversation

quantranhong1999
Copy link
Contributor

WIP: return server fixed expires in JMAP response

@quantranhong1999 quantranhong1999 marked this pull request as ready for review November 3, 2021 05:21
@Arsnael
Copy link
Contributor

Arsnael commented Nov 4, 2021

Could you help rebase please @quantranhong1999 ?

@quantranhong1999
Copy link
Contributor Author

quantranhong1999 commented Nov 4, 2021 •
edited 

org.junit.jupiter.api.extension.ParameterResolutionException: No ParameterResolver registered for parameter [final org.mockserver.integration.ClientAndServer pushServer] in method [public default void org.apache.james.jmap.rfc8621.contract.PushSubscriptionSetMethodContract.setUp(org.apache.james.GuiceJamesServer,org.mockserver.integration.ClientAndServer)]

Look like we need an extension for distributed tests @Arsnael
Can you add

    @RegisterExtension
    static PushServerExtension pushServerExtension = new PushServerExtension();

to 6d5a7f1?

@Arsnael
Copy link
Contributor

Arsnael commented Nov 4, 2021

I don't know at which outdated commit you are looking at but if you mean #726 that piece of code is already there :o

@Arsnael
Copy link
Contributor

Arsnael commented Nov 4, 2021

Just rebase on the last version of it :)

@quantranhong1999 quantranhong1999 force-pushed the pushsub-update-expires branch 3 times, most recently from d2425ad to 6f8217e Compare November 5, 2021 02:53
@chibenwa
Copy link
Contributor

chibenwa commented Nov 8, 2021

(Rebase needed)

@quantranhong1999
Copy link
Contributor Author

image

I rebased latest master and it's green locally.

@vttranlina
Copy link
Contributor

Latest master with me
image

@quantranhong1999
Copy link
Contributor Author

image

My latest master, still green :v

@vttranlina
Copy link
Contributor

My latest master, still green :v

Fixed: #738

@chibenwa chibenwa merged commit b114f1f into apache:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chibenwa chibenwa chibenwa approved these changes

@Arsnael Arsnael Arsnael approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@quantranhong1999 @Arsnael @chibenwa @vttranlina