JAMES-3534 Cassandra implementation for CustomIdentityDAO #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibenwa
approved these changes
Nov 15, 2021
There was a problem hiding this comment.
Looks overall ok to me.
Some work could have been done to enable commutativiry of updates on distinct fields (in a concurrent environment) but this is likely overkill for identities and would complexify the code a lot. So better written like this.
Commutativity: A x B = B x A
Here A -> update replyTo and B -> update bcc
Concurrent scenario exemple
Read A
Read B
Update A
Update B
With the current code A update of replyTo would be lost. By only updating the fields we need we could imagine keeping both updates (but it likely is more complicated!)
...dra/src/main/scala/org/apache/james/jmap/cassandra/identity/CassandraCustomIdentityDAO.scala
Outdated
Show resolved
Hide resolved
...dra/src/main/scala/org/apache/james/jmap/cassandra/identity/CassandraCustomIdentityDAO.scala
Outdated
Show resolved
Hide resolved
.../src/main/scala/org/apache/james/jmap/cassandra/identity/CassandraCustomIdentityModule.scala
Outdated
Show resolved
Hide resolved
quantranhong1999
force-pushed
the
Identity-cassandraDAO
branch
from
06005bd
to
8e81868
Compare
Arsnael
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve linagora#4424