New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JAMES-3534 Implement Identity/set update (custom identities) #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vttranlina
force-pushed
the
identity-set-update
branch
from
November 19, 2021 07:29
d9da48a
to
73a493d
Compare
Arsnael
reviewed
Nov 22, 2021
...tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/IdentitySetContract.scala
Show resolved
Hide resolved
...tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/IdentitySetContract.scala
Outdated
Show resolved
Hide resolved
...tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/IdentitySetContract.scala
Show resolved
Hide resolved
chibenwa
reviewed
Nov 22, 2021
...s/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/IdentitySetUpdatePerformer.scala
Outdated
Show resolved
Hide resolved
...s/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/IdentitySetUpdatePerformer.scala
Outdated
Show resolved
Hide resolved
...s/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/IdentitySetUpdatePerformer.scala
Outdated
Show resolved
Hide resolved
...s/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/IdentitySetUpdatePerformer.scala
Outdated
Show resolved
Hide resolved
...s/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/IdentitySetUpdatePerformer.scala
Outdated
Show resolved
Hide resolved
vttranlina
force-pushed
the
identity-set-update
branch
from
November 22, 2021 10:29
66e33d4
to
1d504f6
Compare
chibenwa
approved these changes
Nov 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks overall good to me!
vttranlina
added a commit
to vttranlina/james-project
that referenced
this pull request
Nov 22, 2021
…om identities)
Arsnael
approved these changes
Nov 23, 2021
vttranlina
force-pushed
the
identity-set-update
branch
from
November 24, 2021 02:23
1d504f6
to
09a16e9
Compare
rebase master & squash fixup |
vttranlina
added a commit
to vttranlina/james-project
that referenced
this pull request
Nov 24, 2021
…om identities)
quantranhong1999
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.apache.org/jira/browse/JAMES-3534
resolve linagora#4429