JAMES-3715 Add TCP transport level tests for IMAP IDLE #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the face of Netty4 migration, pipeline modifications (which IDLE does) deserves to be seriously tested.
- A field can be static - Apply boolean expression simplifications
IDLE listener sends unsolicited notification setted up by the SelectedMailbox listener, thus IDLE listener needs to run after the SelectedMailbox listener. James EventBus provides no such guaranty thus we can run in a data race where IDLE is called first, causing it to never send changes. As a fix, we make SelectedMailbox calling synchronously IDLE listener if needed. IDLE listener no longer need its own registration on the event bus as it is "attached" to the one of SelectedMailbox.
|
|
||
| @Test | ||
| void idleShouldSendInitialContinuation() throws Exception { | ||
| SocketChannel server = SocketChannel.open(); |
There was a problem hiding this comment.
This is more like a client than a server? BTW should we put this SocketChannel.open() into BeforeEach and close it in AfterEach?
There was a problem hiding this comment.
This is more like a client than a server?
Yes we are opening a TCP client connection to test the server.
BTW should we put this SocketChannel.open() into BeforeEach and close it in AfterEach?
👍
Arsnael
reviewed
Mar 14, 2022
| } | ||
|
|
||
| @Test | ||
| void idleShouldResponsesShouldBeOrdered() throws Exception { |
There was a problem hiding this comment.
Suggested change
| void idleShouldResponsesShouldBeOrdered() throws Exception { | |
| void idleResponsesShouldBeOrdered() throws Exception { |
| imapServer.destroy(); | ||
| clientConnection.close(); |
There was a problem hiding this comment.
Shouldn't we close the client connection before destroying the server?
Arsnael
approved these changes
Mar 14, 2022
quantranhong1999
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the face of Netty4 migration, pipeline modifications (which IDLE does)
deserves to be seriously tested.