You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22:14:18,258 [INFO] There are 2 errors reported by Checkstyle 8.29 with checkstyle.xml ruleset.
22:14:18,263 [ERROR] src/main/java/org/apache/james/blob/api/Store.java:[89] (whitespace) EmptyLineSeparator: 'METHOD_DEF' should be separated from previous statement.
22:14:18,264 [ERROR] src/main/java/org/apache/james/blob/api/Store.java:[96] (whitespace) EmptyLineSeparator: 'METHOD_DEF' should be separated from previous statement.
No objections. As it stands it seems to benefit custom code only?
It is used in the BlobStore backed MailRepository of #987 but we felt that the change made sense on its own as there can be multiple MimeMessageStores in a single assembly even before the BlobStore backed Mailrepository.
For example pulsar-cassandra-smtp-relay uses both CassandraMailRepository and the pulsar mailqueue both of which use a MimeMessageStore. As it stands neither adds custom qualifiers while wiring the message store. Unless I am mistaken this means that they will both store their respective blobs in the same bucket. While there are not direct consequences this is doesn't seem to be a very desirable situation.
07:25:20,278 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (check-style) on project james-server-mail-store: You have 1 Checkstyle violation. -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (check-style) on project james-server-mail-store: You have 1 Checkstyle violation.
I can't thank checkstyle enough for this unhelpful message that nicely omits the place where the violation occurs, my workday is starting I will continuer searching what's wrong later
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Matthieu Baechler matthieu@apache.org