[JAMES-3226] drops unused ui-bundle #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibenwa
reviewed
Apr 2, 2021
chibenwa
approved these changes
Apr 2, 2021
|
I think we should keep antora-ui for now I am experimenting with different schemes for modifying the UI I'll do a followup cleanup PR once I have something working in a satisfying way |
Antora supplemental_files are not well documented but they allow to override the UI templates from the UI bundle, not that this mecanisme DOES NOT allow properly overriding UI style, only content and HTML structure.
|
@chibenwa I updated this PR with a couple commits demonstrating how to customize UI, the demo is a proof of concept I didn't spend too much time on styling the icons for example, some of the links are not perfect but it shows how it's done :) |
|
|
|
|
chibenwa
approved these changes
Apr 4, 2021
|
ideally I would prefer to have this merged before merging to live and hard resetting staging :) |
|
Yes, I did not want to hurry too ;uch to give a chance for over people to review this. I am unsure how many people are actively watching this repository. I will merge it now, it is several days already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that an effort to use an customized UI bundle was started and abandonned halfway. The bundle currently isn't used in the website generation and can confuse contributors.
I propose to remove them, since the modifications it contain can now be replicated by using antora supplementary files to override the default UI