Do not assume Owner ID comes first in XML for S3 #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaul
requested changes
Apr 4, 2021
apis/s3/src/main/java/org/jclouds/s3/xml/ListAllMyBucketsHandler.java
Outdated
Show resolved
Hide resolved
timuralp
force-pushed
the
bug/owner-order
branch
from
00e85e1
to
5f7aa50
Compare
Currently, jclouds assumes that the ListBuckets response follows a specific order: the <Owner> tag, followed by the <Buckets> tag. Within the <Owner> tag, jclouds further assumes that the <ID> must occur before the <DisplayName> tag. If the XML body does not adhere to this order, the parser throws a NullPointerException. DigitalOcean spaces does not adhere to this order and returns the <DisplayName> tag before the <ID> tag. The patch changes the parser to not depend on the order of the tags.
timuralp
force-pushed
the
bug/owner-order
branch
from
5f7aa50
to
5c084f2
Compare
|
Thank you for your contribution @timuralp! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, jclouds assumes that the ListBuckets response follows a
specific order: the tag, followed by the tag. Within
the tag, jclouds further assumes that the must occur before
the tag. If the XML body does not adhere to this order,
the parser throws a NullPointerException.
DigitalOcean spaces does not adhere to this order and returns the
tag before the tag. The patch changes the parser to
not depend on the order of the tags.